Conversation
So callers can perform mode changes and removals through the same EMFILE/ENFILE-queueing layer as the other operations.
Merged
2 tasks
zkochan
added a commit
that referenced
this pull request
Apr 30, 2026
* feat(fs.graceful-fs): expose promisified chmod and unlink So callers can perform mode changes and removals through the same EMFILE/ENFILE-queueing layer as the other operations. * chore: remove ENFILE word to satisfy cspell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chmodandunlink(promisified) to@pnpm/fs.graceful-fs's default export so callers can perform mode changes and removals through the same EMFILE-queueing layer as the other operations.@zkochan/cmd-shimrelease that switches its defaultfsimplementation to@pnpm/fs.graceful-fsto fix #11412 (EMFILE: too many open fileson Windows during bin linking in large workspaces).Background
@zkochan/cmd-shim@8.0.0dropped graceful-fs in its ESM rewrite and switched to nativefs.promises.fs.promisesbypasses the userland patches that graceful-fs installs on the callback API, so under high concurrency the writes surfaceEMFILEinstead of waiting for a free file descriptor. cmd-shim needschmodandunlinkto fully replace itsfs.promisesusage with@pnpm/fs.graceful-fs.Test plan
pnpm --filter @pnpm/fs.graceful-fs run compilesucceedschmodandunlinkappear in the generatedlib/index.d.tsastypeof gfs.chmod.__promisify__/typeof gfs.unlink.__promisify__