Skip to content

fix: clean pnpm workspace state during ci#11368

Merged
zkochan merged 1 commit into
pnpm:mainfrom
cyphercodes:fix/ci-clean-workspace-state-11361
Apr 27, 2026
Merged

fix: clean pnpm workspace state during ci#11368
zkochan merged 1 commit into
pnpm:mainfrom
cyphercodes:fix/ci-clean-workspace-state-11361

Conversation

@cyphercodes

Copy link
Copy Markdown
Contributor

Summary

  • include .pnpm-workspace-state-v1.json in the pnpm-owned node_modules entries removed by pnpm clean
  • cover that cleanup path in the existing clean command test
  • add a patch changeset for the CLI fix

Fixes #11361.

Verification

  • pnpm --filter pnpm run compile
  • NODE_OPTIONS="$NODE_OPTIONS --experimental-vm-modules --disable-warning=ExperimentalWarning --disable-warning=DEP0169" pnpm --filter pnpm exec jest test/clean.ts -t 'pnpm clean removes pnpm entries' --runInBand
  • NODE_OPTIONS="$NODE_OPTIONS --experimental-vm-modules --disable-warning=ExperimentalWarning --disable-warning=DEP0169" pnpm --filter pnpm exec jest test/ci.ts -t 'pnpm ci removes node_modules' --runInBand

@cyphercodes cyphercodes requested a review from zkochan as a code owner April 26, 2026 19:27
@welcome

welcome Bot commented Apr 26, 2026

Copy link
Copy Markdown

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

@zkochan zkochan merged commit ece94d2 into pnpm:main Apr 27, 2026
8 checks passed
@welcome

welcome Bot commented Apr 27, 2026

Copy link
Copy Markdown

Congrats on merging your first pull request! 🎉🎉🎉

@theoludwig

Copy link
Copy Markdown

Why was pnpm v11 marked as stable, if there was still this known bug?

Thank you for fixing it, but would have preferred that v11 would include the latest bug fixes.

@zkochan

zkochan commented Apr 29, 2026

Copy link
Copy Markdown
Member

Have you seen the amount of changes shipped in v11? It is impossible to not miss something.

zkochan pushed a commit that referenced this pull request Apr 29, 2026
Co-authored-by: cyphercodes <cyphercodes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pnpm ci leaves almost empty node_modules

3 participants