Conversation
… field is missing Commit 6eedf82 removed the ['.'] fallback for workspacePackagePatterns when pnpm-workspace.yaml has no packages field. This caused findPackages to default to ['.', '**'], discovering ALL directories with package.json as workspace projects. This is the same regression that was previously reverted in 595cd41 (close #10571), reintroduced by #10127. Projects like cdxgen that use pnpm-workspace.yaml only for settings (e.g. minimumReleaseAge) without a packages field were broken because test data directories were picked up as workspace projects. close #10909 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ut packages field Adds a regression test to ensure pnpm-workspace.yaml without a packages field defaults workspacePackagePatterns to ['.'] (root only), preventing all directories from being discovered as workspace projects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Is this change needed here on pnpm/config/config/src/index.ts Line 410 in bb17724 |
dasa
pushed a commit
to dasa/pnpm
that referenced
this pull request
Mar 17, 2026
…s missing (pnpm#10927) * fix: restore ['.'] default for workspacePackagePatterns when packages field is missing Commit 6eedf82 removed the ['.'] fallback for workspacePackagePatterns when pnpm-workspace.yaml has no packages field. This caused findPackages to default to ['.', '**'], discovering ALL directories with package.json as workspace projects. This is the same regression that was previously reverted in 595cd41 (close pnpm#10571), reintroduced by pnpm#10127. Projects like cdxgen that use pnpm-workspace.yaml only for settings (e.g. minimumReleaseAge) without a packages field were broken because test data directories were picked up as workspace projects. close pnpm#10909 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: remove unknown word from changeset Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test(config): verify workspacePackagePatterns defaults to ['.'] without packages field Adds a regression test to ensure pnpm-workspace.yaml without a packages field defaults workspacePackagePatterns to ['.'] (root only), preventing all directories from being discovered as workspace projects. (cherry picked from commit 5163697)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
['.']default forworkspacePackagePatternswhenpnpm-workspace.yamlhas nopackagesfieldfilteronpnpm-workspace.yaml#10127pnpm-workspace.yamlonly for settings (e.g.minimumReleaseAge) without apackagesfield were broken because all directories withpackage.jsonwere discovered as workspace projectsTest plan
@pnpm/configunit test forworkspacePackagePatternspassesrecursive command with filter from configtest to include explicitpackagesfieldpnpm installshould work without discovering test data directories as workspace projectsclose #10909
🤖 Generated with Claude Code