feat(approve-builds): add --all flag to skip interactive prompts#10619
Merged
feat(approve-builds): add --all flag to skip interactive prompts#10619
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a --all flag to the pnpm approve-builds command to enable non-interactive approval of all pending build dependencies. This addresses issue #10136, which describes scenarios where interactive prompts are not feasible, such as CI/CD pipelines and project bootstrapping workflows (e.g., npm create nuxt@latest).
Changes:
- Added
--allboolean flag that bypasses both the package selection prompt and confirmation prompt - All pending build dependencies are automatically approved and set to
allowBuilds: truewhen the flag is used - Comprehensive unit test verifying the flag's behavior and non-interactive operation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| exec/build-commands/src/approveBuilds.ts | Added --all flag support including CLI option registration, help text, type definition, and conditional logic to skip prompts when flag is present |
| exec/build-commands/test/approveBuilds.test.ts | Added comprehensive test case verifying --all flag approves all packages without prompting and generates build artifacts |
| .changeset/approve-builds-all-flag.md | Added changeset documenting the new minor feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
364bb72 to
f36c4e0
Compare
Allow approving all pending build dependencies at once without interactive selection, useful for CI/CD pipelines and project bootstrapping scenarios where interactive prompts are not feasible. Closes pnpm#10136 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
f36c4e0 to
9afda39
Compare
zkochan
approved these changes
Feb 25, 2026
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Can we backport this to 10.x? |
zkochan
pushed a commit
that referenced
this pull request
Mar 8, 2026
) Allow approving all pending build dependencies at once without interactive selection, useful for CI/CD pipelines and project bootstrapping scenarios where interactive prompts are not feasible. close #10136
Member
|
ok 39aa198 |
|
That was quick. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--allflag topnpm approve-buildsthat approves all pending build dependencies at once without interactive selectionnpm create nuxt@latest) where interactive prompts are not feasibleCloses #10136
Test plan
approve all builds with --all flagenquirer.promptis not called when--allis passedpnpm-workspace.yamlwithallowBuilds: trueNote
🤖 This PR was generated with the assistance of an AI coding agent (Claude Code by Anthropic). All code changes have been reviewed and tested by the author.
🤖 Generated with Claude Code