Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in pnpm why -r --parseable where dependents were missing when multiple workspace packages share the same dependency. The issue occurred because when a shared dependency appeared in the results both as a dependency and as a root package, it would be duplicated or omitted incorrectly.
Changes:
- Modified the deduplication logic in
renderParseableto track root packages that have already been output - Added conditional spreading to prevent duplicate output of root package information
- Added comprehensive test coverage for the fix including short format, long format, and edge cases
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
reviewing/list/src/renderParseable.ts |
Fixed deduplication logic to properly track and conditionally output root packages when they appear both as dependencies and in the search results |
reviewing/list/test/index.ts |
Added three new test cases covering shared dependencies in parseable output (short and long format, plus unrelated package exclusion) |
.changeset/fix-why-parseable-dedup.md |
Added changeset documenting the bug fix with minor spelling issue |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "pnpm": patch | ||
| --- | ||
|
|
||
| Fix `pnpm why -r --parseable` missing dependents when multiple workspace packages share the same dependency [#8100](https://github.com/pnpm/pnpm/issues/8100). |
There was a problem hiding this comment.
Spelling: "dependants" should be "dependents" (American English spelling is preferred in technical documentation).
zkochan
added a commit
that referenced
this pull request
Mar 7, 2026
zkochan
added a commit
that referenced
this pull request
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #8100