Skip to content

fix: dynamically calculate column widths in interactive update table#10585

Merged
zkochan merged 3 commits intomainfrom
fix/interactive-update-long-version-wrapping
Feb 13, 2026
Merged

fix: dynamically calculate column widths in interactive update table#10585
zkochan merged 3 commits intomainfrom
fix/interactive-update-long-version-wrapping

Conversation

@ryo-manba
Copy link
Copy Markdown
Member

Fixes #10316

Fixed pnpm update --interactive table breaking when version strings exceed the hardcoded column width of 15 characters.

@ryo-manba ryo-manba marked this pull request as ready for review February 9, 2026 14:37
@ryo-manba ryo-manba requested a review from zkochan as a code owner February 9, 2026 14:37
Copilot AI review requested due to automatic review settings February 9, 2026 14:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +166 to +168
{
message: expect.stringContaining('7.0.0-dev.20251209.1'),
value: '@typescript/native-preview',
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is meant to verify that long versions don’t introduce hard newlines in the rendered table, but the current assertion only checks that the message contains the version substring. It would still pass if the table output contains \n (the original bug) as long as the substring exists. Consider asserting that choices[0].choices[1].message does not include a newline (and ideally also checks the target version column), so the test fails if wrapping is reintroduced.

Copilot uses AI. Check for mistakes.
@ryo-manba
Copy link
Copy Markdown
Member Author

@zkochan Could I merge this?

@zkochan zkochan merged commit fa5a5c6 into main Feb 13, 2026
13 checks passed
@zkochan zkochan deleted the fix/interactive-update-long-version-wrapping branch February 13, 2026 06:13
zkochan pushed a commit that referenced this pull request Mar 7, 2026
…10585)

* fix: dynamically calculate column widths in interactive update table

* test: implement copilot suggestions

* style: change order of functions

close #10316
zkochan pushed a commit that referenced this pull request Mar 7, 2026
…10585)

* fix: dynamically calculate column widths in interactive update table

* test: implement copilot suggestions

* style: change order of functions

close #10316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version string breaks pnpm update --interactive table (@typescript/native-preview: 7.0.0-dev.20251214.1)

3 participants