fix: dynamically calculate column widths in interactive update table#10585
fix: dynamically calculate column widths in interactive update table#10585
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| message: expect.stringContaining('7.0.0-dev.20251209.1'), | ||
| value: '@typescript/native-preview', |
There was a problem hiding this comment.
This test is meant to verify that long versions don’t introduce hard newlines in the rendered table, but the current assertion only checks that the message contains the version substring. It would still pass if the table output contains \n (the original bug) as long as the substring exists. Consider asserting that choices[0].choices[1].message does not include a newline (and ideally also checks the target version column), so the test fails if wrapping is reintroduced.
|
@zkochan Could I merge this? |
Fixes #10316
Fixed
pnpm update --interactivetable breaking when version strings exceed the hardcoded column width of 15 characters.