Conversation
There was a problem hiding this comment.
Pull request overview
This pull request attempts to add support for configuring audit-level in pnpm to address issue #10540, where pnpm audit does not respect the audit-level setting from .npmrc files. The PR adds audit-level configuration to pnpm's config system and adds a corresponding auditLevel property to the Config interface.
Changes:
- Added
audit-levelconfiguration type definition to pnpm's type system - Added
auditLevelproperty to the Config interface - Added
audit-levelto the list of excluded pnpm keys (not allowed in workspace config files) - Set default value for
audit-levelto 'low' - Added changeset documenting the change
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| config/config/src/types.ts | Added audit-level type definition to pnpmTypes with valid values |
| config/config/src/index.ts | Added default value 'low' for audit-level configuration |
| config/config/src/configFileKey.ts | Added audit-level to excludedPnpmKeys list |
| config/config/src/Config.ts | Added auditLevel property to Config interface with correct type |
| .changeset/lucky-bikes-nail.md | Added changeset documenting the feature addition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.changeset/lucky-bikes-nail.md
Outdated
| "@pnpm/config": minor | ||
| --- | ||
|
|
||
| Support configuring `auditLevel` in the workspace file. |
There was a problem hiding this comment.
[Q] Isn't it already supported in pnpm-workspace.yaml?
There was a problem hiding this comment.
Yeah, from the code logic perspective, any configuration written in pnpm-workspace.yaml will be read.
* feat: support `auditLevel` * refactor: auditLevel --------- Co-authored-by: Zoltan Kochan <z@kochan.io>
close #10540