feat: print a warning if network requests are slow#10025
Merged
Conversation
add a new setting for fetch tarball speed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds network performance monitoring to pnpm by implementing warnings for slow network requests, including both metadata fetches and tarball downloads.
Key changes:
- Add configuration options for warning thresholds (
fetchWarnTimeoutMsandfetchMinSpeedKiBps) - Implement timing measurements and speed calculations for network operations
- Display warning messages when requests exceed time thresholds or fall below speed minimums
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
store/store-connection-manager/src/createNewStoreController.ts |
Pass through new fetch warning configuration options |
resolving/npm-resolver/src/index.ts |
Update resolver to use renamed fetch function and pass warning timeout configuration |
resolving/npm-resolver/src/fetch.ts |
Rename function and add timing measurement with warning for slow metadata requests |
pkg-manager/client/src/index.ts |
Add fetchMinSpeedKiBps option to client interface |
fetching/tarball-fetcher/src/remoteTarballFetcher.ts |
Add speed monitoring and warnings for slow tarball downloads |
fetching/tarball-fetcher/src/index.ts |
Wire through speed configuration options |
config/config/src/types.ts |
Define new configuration option types |
config/config/src/index.ts |
Set default values for warning thresholds |
config/config/src/Config.ts |
Add new options to Config interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
vaernion
pushed a commit
to Arbeidstilsynet/brevgen2
that referenced
this pull request
Dec 3, 2025
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pnpm](https://pnpm.io) ([source](https://github.com/pnpm/pnpm/tree/HEAD/pnpm)) | [`10.17.1` -> `10.18.0`](https://renovatebot.com/diffs/npm/pnpm/10.17.1/10.18.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pnpm/pnpm (pnpm)</summary> ### [`v10.18.0`](https://github.com/pnpm/pnpm/blob/HEAD/pnpm/CHANGELOG.md#10180) [Compare Source](pnpm/pnpm@v10.17.1...v10.18.0) ##### Minor Changes - Added network performance monitoring to pnpm by implementing warnings for slow network requests, including both metadata fetches and tarball downloads. Added configuration options for warning thresholds: `fetchWarnTimeoutMs` and `fetchMinSpeedKiBps`. Warning messages are displayed when requests exceed time thresholds or fall below speed minimums Related PR: [#​10025](pnpm/pnpm#10025). ##### Patch Changes - Retry filesystem operations on EAGAIN errors [#​9959](pnpm/pnpm#9959). - Outdated command respects `minimumReleaseAge` configuration [#​10030](pnpm/pnpm#10030). - Correctly apply the `cleanupUnusedCatalogs` configuration when removing dependent packages. - Don't fail with a meaningless error when `scriptShell` is set to `false` [#​8748](pnpm/pnpm#8748). - `pnpm dlx` should not fail when `minimumReleaseAge` is set [#​10037](pnpm/pnpm#10037). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!". 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Related work items: #30372
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.