Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

add github workflow#3

Merged
anonrig merged 4 commits into
mainfrom
add-github-workflows
Jul 13, 2023
Merged

add github workflow#3
anonrig merged 4 commits into
mainfrom
add-github-workflows

Conversation

@anonrig

@anonrig anonrig commented Jul 13, 2023

Copy link
Copy Markdown
Member

No description provided.

@anonrig anonrig merged commit 94da247 into main Jul 13, 2023
@anonrig anonrig deleted the add-github-workflows branch July 13, 2023 02:46
@KSXGitHub KSXGitHub mentioned this pull request Apr 30, 2026
KSXGitHub pushed a commit that referenced this pull request Apr 30, 2026
Applies review finding #3. The trait wraps `std::fs::write`, which is
not atomic — `SIGINT` mid-write leaves a truncated file. Naming it
`FsWriteAtomic` promised a guarantee the implementation does not
deliver and would propagate to every downstream caller.

Drop the misleading suffix. The trait documents explicitly that it
inherits `std::fs::write`'s contract and nothing more. If a future
caller needs atomic semantics (write-tempfile-then-rename), it should
build that on top of `FsWrite` rather than hide the algorithm inside
the capability — keeping the trait minimal lets every callsite see
exactly what guarantees it inherits.

Mechanical rename across the cmd-shim crate and the package-manager
call sites; no behaviour change.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant