This repository was archived by the owner on May 14, 2026. It is now read-only.
refactor: locking of tarball fetching#123
Merged
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 84.99% 85.68% +0.68%
==========================================
Files 24 24
Lines 1393 1411 +18
==========================================
+ Hits 1184 1209 +25
+ Misses 209 202 -7
☔ View full report in Codecov by Sentry. |
Member
Author
|
It works, the issue is that seems like pacquet doesn't currently work with circular dependencies. |
Benchmark ResultsLinux |
anonrig
approved these changes
Sep 19, 2023
zkochan
added a commit
that referenced
this pull request
May 12, 2026
The `// Item #14 will replace this …` / `// Item #15 in #397 …` comments referenced specific items in the audit issue this PR partially closes. Per `CLAUDE.md`: Don't reference the current task, fix, or callers ("used by X", "added for the Y flow", "handles the case from issue #123"), since those belong in the PR description and rot as the codebase evolves. Replaced the substantive WHY (placeholder default until config is plumbed) without naming the issue, and dropped the comments that were just restating the field name. Same applies to the `RunPostinstallHooks.unsafe_perm` doc comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using tokio's notify is a better approach than using a loop.