fix(provisioning): unable to set column defaults on library root#947
Merged
fix(provisioning): unable to set column defaults on library root#947
Conversation
Previously column default values were only set on folders within the library. It possible and sometimes useful to set these values on the library root, which the engine was ignoring. This refactors the code to call `ProcessDefaultFolders` on the library root.
72f1fb9 to
755d7cd
Compare
jansenbe
added a commit
that referenced
this pull request
Dec 11, 2023
nils-a
pushed a commit
to nils-a-forks/pnpframework
that referenced
this pull request
Jan 26, 2024
breaking the page library detection logic
nils-a
added a commit
to nils-a-forks/pnpframework
that referenced
this pull request
Jan 26, 2024
breaking the page library detection logic
jansenbe
added a commit
that referenced
this pull request
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously column default values were only set on folders within the library. It possible and sometimes useful to set these values on the library root, which the engine was ignoring.
This refactors the code to call
ProcessDefaultFolderson the library root.