feat: add @rspack/core as an optional peer dependency#785
Closed
chenjiahan wants to merge 1 commit intopmmmwh:mainfrom
Closed
feat: add @rspack/core as an optional peer dependency#785chenjiahan wants to merge 1 commit intopmmmwh:mainfrom
chenjiahan wants to merge 1 commit intopmmmwh:mainfrom
Conversation
Author
|
@pmmmwh Hi, If you have the time, could you review and provide some feedback 😄 |
Merged
2 tasks
Owner
|
Hey, sorry that I couldn't give this a proper look previously - if the RSPack team is still interested in this I am willing to land this change in the next version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Rspack is a fast Rust-based web bundler and it is compatible with the architecture and ecosystem of webpack.
The
react-refresh-webpack-plugincan be used with Rspack, but users will get a peer dependency warning:Description
This PR adds
@rspack/coreas an optional peer dependency, and make webpack as an optional peer dependency too.Related issues
@rspack/coreto the peer dependencies of html-webpack-plugin and react-refresh-webpack-plugin web-infra-dev/rspack#4537