-
-
Notifications
You must be signed in to change notification settings - Fork 783
Closed
Labels
featNew feature or requestNew feature or requestrsbuildrsbuild relatedrsbuild relatedteamThe issue/pr is created by the member of Rspack.The issue/pr is created by the member of Rspack.
Description
What problem does this feature solve?
Can we add @rspack/core to the peer dependencies of html-webpack-plugin and react-refresh-webpack-plugin (and more popular webpack plugins), then make webpack as an optional dependency?
- https://github.com/jantimon/html-webpack-plugin/blob/main/package.json#L58-L60
- https://github.com/pmmmwh/react-refresh-webpack-plugin/blob/main/package.json#L114-L123
The benifits:
- Users do not need to install webpack as a dependency.
- No peer dependency missing warning.
What does the proposed API of configuration look like?
{
"peerDependencies": {
"@rspack/core": ">=0.3.0",
"webpack": ">=4.43.0 <6.0.0",
},
"peerDependenciesMeta": {
"webpack": {
"optional": true
},
"@rspack/core": {
"optional": true
}
},
}Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
featNew feature or requestNew feature or requestrsbuildrsbuild relatedrsbuild relatedteamThe issue/pr is created by the member of Rspack.The issue/pr is created by the member of Rspack.