Skip to content

fix: get module system scoped to context#768

Merged
pmmmwh merged 3 commits intomainfrom
fix/module-system-cache
Aug 15, 2023
Merged

fix: get module system scoped to context#768
pmmmwh merged 3 commits intomainfrom
fix/module-system-cache

Conversation

@pmmmwh
Copy link
Copy Markdown
Owner

@pmmmwh pmmmwh commented Aug 14, 2023

Fixes #753

@pmmmwh pmmmwh merged commit 4dc633d into main Aug 15, 2023
@pmmmwh pmmmwh deleted the fix/module-system-cache branch August 15, 2023 02:01
@qnighy
Copy link
Copy Markdown

qnighy commented Nov 6, 2023

For those who encountered require is not defined issues after upgrading this package above v0.5.11: try upgrading webpack above v5.85.0 as the change introduced in this PR assumes the API introduced in webpack/webpack#17281

(Not a bug report to this plugin itself. Thank you for the great plugin!)

@Jinjiang
Copy link
Copy Markdown

@pmmmwh I hit an error earlier today with webpack@5.84.1. It's always cjs even the file is inside a node module with type: module in its package.json. I guess that's because older version of webpack doesn't have this.environment in the loader context. Now to work with that I have to downgrade to v0.5.9.

Considering the maximum compatibility, shall we check this.environment with an option? Or skip checking it with an option?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants