Skip to content

fix: correct packageType caching#753

Closed
DarkGenius wants to merge 1 commit intopmmmwh:mainfrom
DarkGenius:fix-getModuleSystem
Closed

fix: correct packageType caching#753
DarkGenius wants to merge 1 commit intopmmmwh:mainfrom
DarkGenius:fix-getModuleSystem

Conversation

@DarkGenius
Copy link
Copy Markdown

Faced the problem of incorrect module type detection. In some cases, a global variable may contain a value for a package other than the package whose file is currently being processed. Adding this.context as a caching key fixes the bug

@pmmmwh
Copy link
Copy Markdown
Owner

pmmmwh commented Jul 7, 2023

Tests are failing 🤔

@pmmmwh pmmmwh force-pushed the fix-getModuleSystem branch from 1210499 to 37a2617 Compare August 14, 2023 09:41
pmmmwh added a commit that referenced this pull request Aug 14, 2023
@pmmmwh pmmmwh closed this in #768 Aug 15, 2023
@DarkGenius DarkGenius deleted the fix-getModuleSystem branch August 15, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants