Skip to content

Added ability to add comments#246

Closed
constantine-prokopenko-vrp wants to merge 7 commits intopmd:mainfrom
constantine-prokopenko-vrp:comments
Closed

Added ability to add comments#246
constantine-prokopenko-vrp wants to merge 7 commits intopmd:mainfrom
constantine-prokopenko-vrp:comments

Conversation

@constantine-prokopenko-vrp
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
I hope I find time the next days to test it (e.g. with a manual integration test -> https://github.com/pmd/pmd-github-action-tests )

@adangel adangel added the enhancement New feature or request label Jan 18, 2024
@adangel
Copy link
Copy Markdown
Member

adangel commented Jan 18, 2024

I tested this now, but unfortunately no comments are created for me. Did you have any success?

I don't see any output from octokit, so I'm not even sure, whether the POST request is executed at all.

Possible problems:

@constantine-prokopenko-vrp
Copy link
Copy Markdown
Author

constantine-prokopenko-vrp commented Feb 1, 2024

Many thanks for your investigation. I'll close the PR for now. I'll reopen PR once I resolve all the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants