Added ability to add comments#246
Closed
constantine-prokopenko-vrp wants to merge 7 commits intopmd:mainfrom
Closed
Added ability to add comments#246constantine-prokopenko-vrp wants to merge 7 commits intopmd:mainfrom
constantine-prokopenko-vrp wants to merge 7 commits intopmd:mainfrom
Conversation
adangel
reviewed
Jan 12, 2024
Member
adangel
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I hope I find time the next days to test it (e.g. with a manual integration test -> https://github.com/pmd/pmd-github-action-tests )
This was referenced Jan 18, 2024
adangel
added a commit
to adangel/pmd-github-action-tests
that referenced
this pull request
Jan 18, 2024
This was referenced Jan 18, 2024
adangel
added a commit
to adangel/pmd-github-action-tests
that referenced
this pull request
Jan 18, 2024
Member
|
I tested this now, but unfortunately no comments are created for me. Did you have any success? I don't see any output from octokit, so I'm not even sure, whether the POST request is executed at all. Possible problems:
|
Author
|
Many thanks for your investigation. I'll close the PR for now. I'll reopen PR once I resolve all the issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.