[apex] Fix #3877: ApexCRUDViolation false positive on Lists of Objects with getSObjectType().getDescribe()#6769
Merged
adangel merged 1 commit intoJun 11, 2026
Conversation
…ects with getSObjectType().getDescribe()
Contributor
|
Compared to main: (comment created at 2026-06-10 06:18:59+00:00 for 4d319f9) |
adangel
added a commit
that referenced
this pull request
Jun 11, 2026
adangel
added a commit
that referenced
this pull request
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Fix false positive in ApexCRUDViolation rule when using
getSObjectType().getDescribe()CRUD check pattern on custom objects.Related issue
How to review
The issue is that the existing
getDescribe()handler incollectCRUDMethodLevelChecksexpects the method call's reference expression to have names ending withsObjectType(e.g.,Contact.sObjectType.getDescribe()). However, forCustomObject__c.getSObjectType().getDescribe(),getSObjectType()is a method call — so the reference ofgetDescribe()has no names, andgetSObjectType()is a child of that reference expression rather than a direct child ofgetDescribe().The fix adds a new
else ifbranch that checks for this pattern by traversing the reference expression ofgetDescribe()to find thegetSObjectType()call and extract the SObject type name.Test cases added
getSObjectType().getDescribe()with single object DML — expects 0 violationsgetSObjectType().getDescribe()with List DML — expects 0 violationsgetSObjectType().getDescribe()with wrong CRUD check — expects 1 violationAll 911 existing tests pass (0 failures).