[java] Fix in Java grammar: Try with final resource node error#675
Merged
Conversation
Member
|
@gibarsin very nice find! |
Member
|
This reminded me we are missing cases on |
jsotuyod
added a commit
that referenced
this pull request
Oct 18, 2017
Member
|
Merged for 6.0.0! Thanks for the PR! |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When running the designer with the following code: https://pastebin.com/xGrHQ3QN I noticed that the Resource node contained in the Resources node has its isFinal boolean value set to false. After checking the grammar, I noticed the issue here:
pmd/pmd-java/etc/grammar/Java.jjt
Line 2256 in 5321084
How I solved it
When a final token is found, the isFinal value is currently not set to true. The solution is to invoke
{jjtThis.setFinal(true);}to the right of"final"