[java] Part of #4841: Deprecate unnecessary public methods in FieldDeclarationsShouldBeAtStartOfClassRule/CyclomaticComplexityRule/SwitchDensityRule#6671
Merged
Conversation
3b4cb7e to
509d5ee
Compare
Contributor
|
Compared to main: (comment created at 2026-05-27 12:48:53+00:00 for 39fe4e8) |
5061925 to
c7ca036
Compare
UncleOwen
added a commit
to UncleOwen/pmd
that referenced
this pull request
May 15, 2026
UncleOwen
added a commit
to UncleOwen/pmd
that referenced
this pull request
May 15, 2026
7ff2cd2 to
9096ffa
Compare
UncleOwen
added a commit
to UncleOwen/pmd
that referenced
this pull request
May 15, 2026
9096ffa to
df6babd
Compare
UncleOwen
added a commit
to UncleOwen/pmd
that referenced
this pull request
May 22, 2026
df6babd to
893b18c
Compare
adangel
reviewed
May 25, 2026
adangel
left a comment
Member
There was a problem hiding this comment.
Thanks!
Can you try to use the {% javadoc macro in the release notes?
Note: I already renamed this PR, you'll need to update the release notes...
Apart from that, the changes look fine.
fd6d6a1 to
544947b
Compare
UncleOwen
added a commit
to UncleOwen/pmd
that referenced
this pull request
May 25, 2026
544947b to
00281fc
Compare
FieldDeclarationsShouldBeAtStartOfClassRule.visit(ASTTypeDeclaration, Object) CyclomaticComplexityRule.visitTypeDecl(ASTTypeDeclaration, Object) SwitchDensityRule.visitSwitchLike(ASTSwitchLike, Object) There is no need for these methods to be public, so I deprecated them. This also serves as a prototype for future work on pmd#4814. Completely closing this issue will require a major release, but we can still do a lot, I believe.
UncleOwen
added a commit
to UncleOwen/pmd
that referenced
this pull request
May 27, 2026
UncleOwen
added a commit
to UncleOwen/pmd
that referenced
this pull request
May 27, 2026
aed4427 to
39fe4e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR deprecates 3 methods I found in #6586:
There is no need for these methods to be public, so I deprecated them.
This also serves as a prototype for future work on #4814. Completely closing this issue will require a major release, but we can still do a lot, I believe.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)