[swift] Fix invalid swift token OSXApplicationExtension#6654
Merged
Conversation
Contributor
|
Compared to main: (comment created at 2026-05-08 09:52:31+00:00 for f3f7a2b) |
adangel
added a commit
to UncleOwen/pmd
that referenced
this pull request
May 8, 2026
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for upgrading antlr, see #4972 / #6621
Note: Unfortunately, the generated parser is public API - removing a token is a breaking change. We need #5136 but for the antlr based language modules.
So, this means, the hyphen on
OSXApplicationExtension-has to stay, so that this is a token on its own (there is alreadyOSXApplicationExtension).Eventually, these tokens should be removed, they are not keywords and not even context sensitive keywords in swift.