Up to standards ✅

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback}

Documentation Preview

No relevant source code has been changed, pmdtester skipped.

(comment created at 2026-05-10 12:42:18+00:00 for da69544)

Thanks for continuing this work.

I don't understand what is meant by "Update pom.xml to exclude generated-sources/... etc also for "pmd-test" execution (excludeRoots)" in the original PR. Could someone enlighten me?

This is about the configuration of the maven-pmd-plugin:

By default, m-pmd-p will use all compile source roots (see https://maven.apache.org/plugins/maven-pmd-plugin/pmd-mojo.html#compileSourceRoots) and test source roots ( https://maven.apache.org/plugins/maven-pmd-plugin/pmd-mojo.html#testSourceRoots ).
When you use the defaults, you can use https://maven.apache.org/plugins/maven-pmd-plugin/pmd-mojo.html#excludeRoots to remove some directory.
However, we already explicitly set the compile source roots, so we don't use an exclude. This is the case for the "pmd-main" execution.

Now, for the "pmd-test" execution: (Btw - we use different executions to have different rulesets for the tests classes) We now need to make sure, that we only analyze src/test/java and not src/test/java-resources . We might need to set includeTests=false - as otherwise all the test roots you added with build-helper-maven-plugin would be analyzed. I think, we added src/test/java as compileSourceRoot and not as testSourceRoot because m-pmd-p doesn't support to run on only on tests - it only support main or main+test combinations. So, we sell in the "pmd-test" execution main for test...

Since we are introducing "src/test/java-resources" now only for the pmd-java module and not for the others, we should probably leave the config in the parent-pom as is and adjust the config for pmd-java only:

The problem, we want to solve with all this is: Can we now enable UnusedPrivateMethod in https://github.com/pmd/build-tools/blob/main/src/main/resources/net/sourceforge/pmd/pmd-test-dogfood-config.xml ? Did you try this? Does it work?

There are some other tasks on the original PRs:

• Need to update checkstyle suppressions in build tools

Do we want to run checkstyle against src/test/java-resources?
Currently, checkstyle only excludes generated-sources. The configuration we have says, it should apply the rules to the test sources as well. So maybe we need to exclude src/test/java-resources?
I don't see, that we need to change the build-tools config for that (https://github.com/pmd/build-tools/blob/main/src/main/resources/net/sourceforge/pmd/pmd-checkstyle-suppressions.xml ) but only the java-specific override in pmd-java (https://github.com/pmd/pmd/blob/main/pmd-java/pmd-java-checkstyle-suppressions.xml )

I read somewhere that checkstyle is used to verify the license header. That part applies to src/test/java-resources as well.

Apart from that, I believe I have addressed all your comments. I tested with a locally installed version of build-tools, where I added

    <rule ref="category/java/bestpractices.xml/UnusedPrivateMethod">
        <priority>1</priority>
    </rule>

to pmd-test-dogfood-config. The build is green, and if I add a unused private method to one of the tests, the build turns red.

Thank you @UncleOwen and @adangel for bringing this to the finish line 🎉