Merged
Conversation
Contributor
|
Compared to main: (comment created at 2026-01-23 16:11:21+00:00 for 9df9504) |
zbynek
commented
Dec 27, 2025
...a/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UselessParentheses.xml
Show resolved
Hide resolved
adangel
reviewed
Jan 23, 2026
Comment on lines
+43
to
+48
| # public APIs | ||
| isWilcardParameterized="isWilcardParameterized" | ||
| checkSelfDescendantAbreviation="checkSelfDescendantAbreviation" | ||
| ColonSubsript="ColonSubsript" | ||
| XMLTableColum="XMLTableColum" | ||
| ASTXMLTableColum="ASTXMLTableColum" |
Member
There was a problem hiding this comment.
For these misspelled public APIs we should probably create a separate PR, add a fixed version of the method and deprecate the old one.
adangel
reviewed
Jan 23, 2026
adangel
reviewed
Jan 23, 2026
adangel
reviewed
Jan 23, 2026
adangel
reviewed
Jan 23, 2026
adangel
approved these changes
Jan 23, 2026
Member
adangel
left a comment
There was a problem hiding this comment.
Thanks!
Before I merge it, I want to test typos locally as well. I think, it would make sense to run it in CI at least for pull requests.
adangel
added a commit
that referenced
this pull request
Jan 23, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Follow-up for #5980
With these changes a check using https://github.com/crate-ci/typos version 40.0 passes on this repo.
The
typos.tomlfile is added to simplify running that tool locally, can be added to CI if desirable.Related issues
Ready?
Added unit tests for fixed bug/feature./mvnw clean verifypasses (checked automatically by github actions)Added (in-code) documentation (if needed)