[java] Fix #4257: Allow ignoring methods in OnlyOneReturn #6309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce the property ignoredMethodNames, which defaults to compareTo and equals as common methods with multiple returns. The property is a String List to align with other ignore properties: ignoredFieldNames and ignoredAnnotations.
Contributor
|
Compared to main: (comment created at 2025-12-04 17:06:52+00:00 for 94896cd) |
adangel
approved these changes
Dec 22, 2025
Member
adangel
left a comment
There was a problem hiding this comment.
Thanks!
I'll add another test case to verify, that the old behavior still can be enabled by just setting the new property to an empty value.
adangel
added a commit
that referenced
this pull request
Dec 22, 2025
adangel
added a commit
that referenced
this pull request
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Introduce the property
ignoredMethodNames, which defaults tocompareToandequals. The property is a String List (instead of regex) to align with the other ignore* properties ignoredFieldNames and ignoredAnnotations.Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)