Skip to content

[java] Reactivate deactivated test in LocalVariableCouldBeFinal#6043

Merged
adangel merged 1 commit into
pmd:mainfrom
UncleOwen:issue-3122-reactivate-test
Sep 25, 2025
Merged

[java] Reactivate deactivated test in LocalVariableCouldBeFinal#6043
adangel merged 1 commit into
pmd:mainfrom
UncleOwen:issue-3122-reactivate-test

Conversation

@UncleOwen

Copy link
Copy Markdown
Member

Describe the PR

See #3122. Turns out, the code already works. Just need to make sure the variable is used.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)

@pmd-actions-helper

pmd-actions-helper Bot commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Documentation Preview

No regression tested rules have been changed.

(comment created at 2025-09-25 10:13:09+00:00 for dc0a557)

@adangel adangel added this to the 7.18.0 milestone Sep 25, 2025
See pmd#3122. Turns out, the code already works. Just need to make sure the
variable is used.
@adangel adangel force-pushed the issue-3122-reactivate-test branch from 8445e22 to dc0a557 Compare September 25, 2025 09:55

@adangel adangel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

adangel added a commit that referenced this pull request Sep 25, 2025
@adangel adangel merged commit dc0a557 into pmd:main Sep 25, 2025
1 check passed
@UncleOwen UncleOwen deleted the issue-3122-reactivate-test branch September 25, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[java] LocalVariableCouldBeFinal should consider blank local variables

2 participants