Skip to content

chore: Fix JUnit warning about invalid test factory #5894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adangel merged 5 commits into from
Jul 22, 2025
Merged

chore: Fix JUnit warning about invalid test factory #5894

adangel merged 5 commits into from
Jul 22, 2025

Conversation

@adangel
Copy link
Member

@adangel adangel commented Jul 10, 2025 •
edited
Loading

Describe the PR

This fixes the following warnings during build (they appeared at some point after a junit upgrade):

2025-07-08T17:55:43.6126480Z Jul 08, 2025 5:55:43 PM org.junit.platform.launcher.core.DiscoveryIssueNotifier logIssues
2025-07-08T17:55:43.6127957Z WARNING: TestEngine with ID 'junit-jupiter' encountered 2 non-critical issues during test discovery:
2025-07-08T17:55:43.6129584Z 
2025-07-08T17:55:43.6131442Z (1) [WARNING] @TestFactory method 'public void net.sourceforge.pmd.lang.java.types.SubtypingTest.primer()' must return a single org.junit.jupiter.api.DynamicNode or a Stream, Collection, Iterable, Iterator, Iterator provider, or array of org.junit.jupiter.api.DynamicNode. It will not be executed.
2025-07-08T17:55:43.6133978Z     Source: MethodSource [className = 'net.sourceforge.pmd.lang.java.types.SubtypingTest', methodName = 'primer', methodParameterTypes = '']
2025-07-08T17:55:43.6135380Z             at net.sourceforge.pmd.lang.java.types.SubtypingTest.primer(SourceFile:0)
2025-07-08T17:55:43.6135899Z 
...

It seems, that we still need this IntelliMarker, as without it, gutter icons in IntelliJ IDEA won't show up. Also not with the kotest intellij plugin.

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 7.16.0 milestone Jul 10, 2025
@adangel adangel added the in:testing About tests of pmd, eg the module pmd-lang-test or pmd-test [test] label Jul 10, 2025
@github-actions
Copy link

github-actions bot commented Jul 10, 2025 •
edited
Loading

Documentation Preview

No regression tested rules have been changed.

(comment created at 2025-07-22 17:36:43+00:00 for bad04ba)

@UncleOwen

This comment was marked as resolved.

Sign in to view
@adangel adangel merged commit 9d6c5a1 into pmd:main Jul 22, 2025
1 check passed
@adangel adangel deleted the chore/fix-junit-jupiter-warnings branch July 22, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in:testing About tests of pmd, eg the module pmd-lang-test or pmd-test [test]

Projects

None yet

Milestone

7.16.0

Development

Successfully merging this pull request may close these issues.

2 participants

@adangel @UncleOwen