[core] Properties refactoring: Move static constants of ValueParser to class ValueParserConstants#587
Merged
Merged
Conversation
6 tasks
jsotuyod
reviewed
Sep 10, 2017
jsotuyod
left a comment
Member
There was a problem hiding this comment.
Sorry I didn't look into this earlier!
| * @since 6.0.0 | ||
| */ | ||
| //TODO: make package-private when we move everything to n.s.pmd.properties | ||
| public final class ValueParsers { |
Member
There was a problem hiding this comment.
I like the idea of moving these out, but I believe we need a different name.
In general, it's a a code smell to have classes differing on a single char, specially plurals
Member
Author
There was a problem hiding this comment.
Maybe ValueParserConstants then ?
jsotuyod
added a commit
that referenced
this pull request
Sep 12, 2017
Member
|
Very late, but finally merged! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a PR, please check that:
master. The PMD team will merge back to support branches as needed.mvn testpasses.mvn checkstyle:checkpasses. Check this for more infoPR Description: Checks item 2 of #504