[core] add IDE agnostic configuration with Maven Spotless Plugin#5867
Closed
Pankraz76 wants to merge 2 commits into
Closed
[core] add IDE agnostic configuration with Maven Spotless Plugin#5867Pankraz76 wants to merge 2 commits into
Maven Spotless Plugin#5867Pankraz76 wants to merge 2 commits into
Conversation
13273fe to
4c6748d
Compare
importOrder with Maven Spotless PluginMaven Spotless Plugin
Pankraz76
commented
Jun 30, 2025
Pankraz76
left a comment
Contributor
Author
There was a problem hiding this comment.
proof of concept.
| <!--lineEndings>UNIX</lineEndings--> | ||
| <!--formats> | ||
| <format> | ||
| <endWithNewline /> |
Contributor
Author
There was a problem hiding this comment.
its important that align, on what is an random impl. detail.
You should define the styles, then simply apply what you like, or remove.
Simply checkout and run the build to see diff.
|
Compared to main: (comment created at 2025-07-02 12:47:03+00:00 for 846019b) |
Contributor
Author
Pankraz76
commented
Jul 2, 2025
Pankraz76
commented
Jul 2, 2025
Pankraz76
left a comment
Contributor
Author
There was a problem hiding this comment.
google is outdated
Member
That's not a good argument - we don't change something, just for the sake of having it changed... |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkstyleburden imposed ontrimTrailingWhitespaceandremoveUnusedImportswithMaven Spotless Plugin#5848just like quarkus having eclipse config in place make is the perfect candidate for auto fix static analysis with spotless.
Eclipse Formatter ProfileintoMaven Spotless Pluginquarkusio/quarkus#48041Eclipse Formatter ProfileintoMaven Spotless Pluginspring-projects/spring-framework#34978maven has check and spot so of course its possible to have both but actually spot covers what check does in ideal making it redundant.
as seen in quarkus they have aligned config having seen here changed 7 years ago its clear thats its out of date: