Skip to content

Automatically fix Checkstyle violations#5890

Closed
Pankraz76 wants to merge 12 commits into
pmd:mainfrom
Pankraz76:rewrite-Automatically-fix-Checkstyle-violations-
Closed

Automatically fix Checkstyle violations#5890
Pankraz76 wants to merge 12 commits into
pmd:mainfrom
Pankraz76:rewrite-Automatically-fix-Checkstyle-violations-

Conversation

@Pankraz76

@Pankraz76 Pankraz76 commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

blocked by:

Describe the PR

Related issues

  • Fix #

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)


public static int numAlternatives(ASTSwitchBranch n) {
return n.isDefault() ? 1 : n.getLabel().getExprList().count();
return n.isDefault() ? 1 : n.getLabel().getExprList().count();

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

challenge rewrite to fix this.

@adangel

adangel commented Jul 8, 2025

Copy link
Copy Markdown
Member

Would you mind stopping to create pull requests that serve only your own experiments/challenges? If you want to work on openrewrite and use PMD's code for that, you are free to do so. But please, do it in your own fork and do not create pull requests.
Thank you.

@adangel adangel closed this Jul 8, 2025
@Pankraz76

Copy link
Copy Markdown
Contributor Author

Yes doing so on my fork is the right way to do.
Did not came into my mind, yet. Thanks for telling me.

your own

it was actually kind of suggested by @oowekyala as he mentioned to use rewrite instead or spot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants