Skip to content

Conversation

@adangel
Copy link
Member

@adangel adangel commented May 15, 2025

Describe the PR

  • Converted all necessary jobs
  • correct <deploymentName>${project.artifactId}</deploymentName> for central-publishing-maven-plugin
    • should simply be "PMD ${project.version}"
    • otherwise the plugin chooses the last artifactId as the name, which is a bit confusing
  • Upload pmd-regression-tester baselines to sourceforge for archiving
  • Update documentation -> github_actions_workflows.md
  • Update do-release.sh and releasing.md (docs)
  • Try to test this somehow
    • Consider idempotency - if some part fails for external reasons (network unavailable...), we want to redo it, if possible
  • After merge: remove repository secrets MAVEN_CENTRAL_PORTAL_USERNAME/PASSWORD - should only be in environment

Postponed

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 7.15.0 milestone May 15, 2025
@adangel adangel mentioned this pull request May 15, 2025
14 tasks
@adangel adangel added github_actions Pull requests that update Github_actions code in:pmd-internals Affects PMD's internals labels May 15, 2025
@github-actions
Copy link

github-actions bot commented May 15, 2025

Documentation Preview

Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.

Regression Tester Report

(comment created at 2025-06-26 13:21:46+00:00 for 6462b0c)

adangel added 6 commits June 9, 2025 15:51
- add SNAPSHOT links
- add latest links
- github-release
- create-sourceforge-blog-post
- create-regression-tester-baseline
- create-docker
That way, a new SNAPSHOT is available sooner and PR don't fail
(because of missing regression tester baseline)
@adangel adangel force-pushed the ci/new-release-build branch from ab68cc0 to 85eda52 Compare June 9, 2025 15:46
@adangel adangel marked this pull request as ready for review June 19, 2025 14:39
@adangel
Copy link
Member Author

adangel commented Jun 19, 2025

I decided to postpone the task "Figure out a solution when pmd-designer needs to be released at the same time": After the switch from 6.x to 7.x, we didn't need this "feature" yet. Just releasing everything at once when releasing PMD is much simpler, as we don't need to maintain two different release cases (a) release pmd-designer in the middle, and b) no pmd-designer release).

That means: if the situation arises, that we would need a new pmd-designer version, but the new pmd-designer version would need a new pmd version, then we might try to create a manual (deploy to maven central only) pre-release of only pmd-core, allowing to release pmd-designer before the "real" release of pmd is happening.

Comment on lines +115 to +116
-Dmaven.javadoc.skip=false \
-Dmaven.source.skip=false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a fix that maybe should be extracted out of this PR, as it affects the snapshot builds.
Currently, no sources and javadoc artifacts are available at https://central.sonatype.com/service/rest/repository/browse/maven-snapshots/net/sourceforge/pmd/pmd-core/

- use correct cache key for regression tester
- cleanup gpg key
- create correct docs.pmd-code.org/latest symlink
@adangel adangel merged commit 5e2bf35 into pmd:main Jun 26, 2025
12 checks passed
@adangel adangel deleted the ci/new-release-build branch June 26, 2025 14:09
adangel added a commit that referenced this pull request Jun 27, 2025
adangel added a commit that referenced this pull request Jun 27, 2025
adangel added a commit that referenced this pull request Jun 27, 2025
adangel added a commit that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code in:pmd-internals Affects PMD's internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant