Skip to content

Fix #5079: [java] LocalVariableCouldBeFinal false-positive with lombok.val #5600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adangel merged 2 commits into from
Mar 27, 2025
Merged

Fix #5079: [java] LocalVariableCouldBeFinal false-positive with lombok.val #5600

adangel merged 2 commits into from
Mar 27, 2025

Conversation

@oowekyala
Copy link
Member

@oowekyala oowekyala commented Mar 15, 2025

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@github-actions
Copy link

github-actions bot commented Mar 15, 2025 •
edited
Loading

Documentation Preview

Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.

Regression Tester Report

@adangel adangel changed the title [java] Fix #5079 - LocalVariableCouldBeFinal false-positive with lombok.val Fix #5079: [java] LocalVariableCouldBeFinal false-positive with lombok.val Mar 25, 2025
@adangel adangel self-requested a review March 25, 2025 19:28
@adangel adangel mentioned this pull request Mar 27, 2025
Open
@adangel adangel added this to the 7.12.0 milestone Mar 27, 2025
adangel
adangel approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel adangel merged commit fda7b74 into pmd:main Mar 27, 2025
12 checks passed
adangel added a commit to adangel/pmd that referenced this pull request Mar 27, 2025
@adangel
[doc] Update release notes (pmd#5600, pmd#5079)
64a925a
adangel added a commit that referenced this pull request Mar 27, 2025
@adangel
Fix #5079: [java] LocalVariableCouldBeFinal false-positive with lombo…
6d491a8 
…k.val (#5600)

Merge pull request #5600 from oowekyala:issue5079-lombok-val-final
@oowekyala oowekyala deleted the issue5079-lombok-val-final branch March 27, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adangel adangel adangel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.12.0

Development

Successfully merging this pull request may close these issues.

[java] LocalVariableCouldBeFinal false-positive with lombok.val

2 participants

@oowekyala @adangel