Fix #5442: [java] Fix stackoverflow with recursive generic types#5528
Merged
Conversation
I wasn't able to create source that triggers the bug without going creating a new code path...
Generated by 🚫 Danger |
adangel
reviewed
Feb 20, 2025
adangel
added a commit
that referenced
this pull request
Feb 20, 2025
adangel
added a commit
that referenced
this pull request
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I unfortunately wasn't able to create source that triggers the bug. I identified the infinite loop from the stack trace, and had to add a new entry point to the convertibility visitor to fall into it.#5505 provided a test case.Describe the PR
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)