[java] Allow lambdas with unresolved target types to succeed inference#5339
Merged
[java] Allow lambdas with unresolved target types to succeed inference#5339
Conversation
This prevents failures in code that uses lambdas
Generated by 🚫 Danger |
adangel
approved these changes
Nov 22, 2024
| private void foo(int y, FunctionalItf x) { | ||
| } | ||
| private void foo(FunctionalItf x) { | ||
| return SummaryDto.ItemDto.builder().build(); |
Member
There was a problem hiding this comment.
I'll remove this return, as foo is void.
| return SummaryDto.ItemDto.builder().build(); | ||
| } | ||
| private <T extends FunctionalItf> T bar(T x) { | ||
| return SummaryDto.ItemDto.builder().build(); |
Member
There was a problem hiding this comment.
I'll just do return x; here to avoid bringing SummaryDto etc. into context (which are also unresolved).
adangel
added a commit
that referenced
this pull request
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents failures in code that uses lambdas but doesn't have a full classpath. In particular, UnusedPrivateMethod used to report failures in this case.
Describe the PR
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)