Skip to content

[doc] Document rule changes for PMD 7#4501

Merged
adangel merged 22 commits into
pmd:masterfrom
adangel:doc-pmd7-rule-changes
Apr 29, 2023
Merged

[doc] Document rule changes for PMD 7#4501
adangel merged 22 commits into
pmd:masterfrom
adangel:doc-pmd7-rule-changes

Conversation

@adangel

@adangel adangel commented Apr 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 7.0.0 milestone Apr 23, 2023
@ghost

ghost commented Apr 23, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown
1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 0 configuration errors.
Full report
✅ No regression tested rules have been changed.

Generated by 🚫 Danger

@adangel adangel mentioned this pull request Apr 24, 2023
Closed
55 tasks
adangel added 9 commits April 27, 2023 08:35
@adangel
[doc] Sort changed rules in release notes
7acb2f4
@adangel
[java] AvoidReassigningLoopVariables - update test case, document dif…
9064297 
…ferences

Refs pmd#4500
Refs pmd#3123
@adangel
[doc] Document changes on report location
d718d3f 
Refs pmd#4439
Refs pmd#730
Refs pmd#3123
@adangel
[doc] ArrayIsStoredDirectly - reports now on assignment
72d9fd6 
and not anymore on formal parameter.

Refs pmd#3127
Refs pmd#3123
@adangel
[doc] Document removed rule properties
aa38d60 
Refs pmd#3123
@adangel
[java] SwitchDensityRule - use common report level property for "mini…
3fab198 
…mum"

While we calculate the ratio between number of statements and number of labels,
we shouldn't pretend that this is an exact rule - it's anyway a best guess,
that high switch density is a problem. I don't think, it makes a big difference
between 10.2 and 10. You e.g. want to report, when the density is bigger than 10
or bigger than 5. We don't need the report level accuracy here.

Refs pmd#3123
@adangel
[doc] Document removed properties for statistical rules
c9c8515
@adangel
[doc] Update issue titles in fixed issues section
1d05aad
@adangel
[doc] Update violationSuppressXPath XPath version changes
efbbd6c
@adangel adangel force-pushed the doc-pmd7-rule-changes branch from 31be09a to efbbd6c Compare April 27, 2023 07:23
oowekyala
oowekyala reviewed Apr 27, 2023
View reviewed changes
Comment thread docs/pages/release_notes.md Outdated
@adangel adangel marked this pull request as ready for review April 28, 2023 07:34
@adangel

adangel commented Apr 28, 2023

Copy link
Copy Markdown
Member Author

So, that's finally ready now.

Most important points:

@adangel adangel merged commit e493db6 into pmd:master Apr 29, 2023
adangel added a commit to adangel/pmd that referenced this pull request Apr 29, 2023
@adangel
Merge pull request pmd#4501 from adangel:doc-pmd7-rule-changes
b3fe03f 
[doc] Document rule changes for PMD 7 pmd#4501
@adangel adangel deleted the doc-pmd7-rule-changes branch April 29, 2023 21:09
@adangel adangel mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment