Merged
Conversation
Don't override "finalName" anymore. This however changes the filenames of the generated binary distribution files.
This was referenced Apr 6, 2023
Generated by 🚫 Danger |
adangel
added a commit
to adangel/pmd-regression-tester
that referenced
this pull request
May 26, 2023
adangel
added a commit
to pmd/build-tools
that referenced
this pull request
Jun 1, 2023
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Jun 1, 2023
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Jun 1, 2023
Updates build-tools to 22-SNAPSHOT Refs pmd#4460
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Don't override "finalName" anymore. This however changes the filenames of the generated binary distribution files.
This fixes the following warnings and make sure, we can build PMD when overriding these properties won't be possible anymore:
Note: this is a 💥 breaking change: As the filename is changed, you might need to update your download/extract scripts.
Therefore, this change impacts also pmd-github-action and the landing page pmd.github.io.
Note 2: I've changed the filename for the doc.zip the same way for consistency.
Note 3: The content inside the zip-files stays the same: We still provide a base directory called
pmd-bin-<version>.Ready?
./mvnw clean verifypasses (checked automatically by github actions)