Skip to content

[java] Make ASTVariableDeclarator not be a TypeNode#4351

Merged
adangel merged 1 commit into
pmd:pmd/7.0.xfrom
oowekyala:pmd7.java-typenodes
Jan 30, 2023
Merged

[java] Make ASTVariableDeclarator not be a TypeNode#4351
adangel merged 1 commit into
pmd:pmd/7.0.xfrom
oowekyala:pmd7.java-typenodes

Conversation

@oowekyala

Copy link
Copy Markdown
Member

Describe the PR

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added an:enhancement An improvement on existing features / rules in:ast About the AST structure or API, the parsing step labels Jan 23, 2023
@oowekyala oowekyala added this to the 7.0.0 milestone Jan 23, 2023

@adangel adangel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'll fix the unit test and merge it.

adangel added a commit that referenced this pull request Jan 30, 2023
[java] Make ASTVariableDeclarator not be a TypeNode #4351
@adangel adangel merged commit d2db395 into pmd:pmd/7.0.x Jan 30, 2023
@oowekyala oowekyala deleted the pmd7.java-typenodes branch January 30, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

an:enhancement An improvement on existing features / rules in:ast About the AST structure or API, the parsing step

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants