[visualforce] Replace uses of Jorje types in pmd-visualforce#4226
Merged
adangel merged 4 commits intoNov 25, 2022
Merged
Conversation
Summary: store and compare primitive type names instead of using BasicType enum. Udpate unit tests and add a few more cases. Change-Id: If4e5bb33d11793813839b82cf8beb043aad2ce34
Generated by 🚫 Danger |
Change-Id: I3499dc615262612b6c220b7840d3ab8cca87c226
b93d8a6 to
c9e21cd
Compare
adangel
reviewed
Nov 24, 2022
adangel
left a comment
Member
There was a problem hiding this comment.
Thanks.
I think, we should keep the method that takes Jorje's BasicType but deprecated it (for the holy compatibility reason).
Isolate references to BasicType inside method implementation. Change-Id: I4be2ad5b8b42fb7a84da0755106d8f0b08034690
Change-Id: I0aa6ecfeb343f2e0b48d2ebfd176a877a72f40f6
adangel
added a commit
that referenced
this pull request
Nov 25, 2022
adangel
added a commit
that referenced
this pull request
Nov 25, 2022
…-for-visualforce [visualforce] Replace uses of Jorje types in pmd-visualforce #4226
This was referenced Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store and compare primitive type names as Strings instead of using Jorje BasicType enum.
Rewrote some logic using PMD AST instead of raw Jorje nodes.
There ought to be no change in behavior.
Update unit tests and add a few more cases.
In furtherance of: #3766