[apex] Summit-AST Apex module - Part 5 - annotations, triggers, misc.#4219
Merged
adangel merged 22 commits intoDec 1, 2022
Merged
Conversation
Change-Id: Ibb474f3704246fce86f6e1dec6f505a817ca8082
Change-Id: If9e6874b0a2d906da161116ba71176049df2a86c
Change-Id: Idaf68b2641443c73aa9b39d3d801c189ecdf9638
- Sort annotation names - Make names lowercase - Use set for names
- Use ImmutableMap
- Handle only `LiteralExpression`s; rename to `literalToString` - Manually discard other `Expression`s at each client
Change-Id: Iec30525f2b7f2bf41432df4153b56339378ccbf7
Change-Id: I5f5d5d6bc822e6367828e75dbaa3c274af9934ec
Change-Id: I3ffd845161d8c0604fa8aa8baac6996dcca4c93c
Change-Id: Ib198889016e81e4c5b4490879e76d492d9edbf99
* Make ctor package private * ASTExpressionStatement should wrap ExpressionStatement not Expression Change-Id: Iab7db02ea5bcc55b9e21f9fa3193105abb15bc17
16 tasks
80e38b2 to
07c974c
Compare
adangel
approved these changes
Dec 1, 2022
| import net.sourceforge.pmd.annotation.InternalApi; | ||
|
|
||
| public class ASTField extends AbstractApexNode.Single<Node> implements CanSuppressWarnings { | ||
| import com.beust.jcommander.internal.Nullable; |
Member
There was a problem hiding this comment.
That's unused - I'll remove it before merging
adangel
added a commit
that referenced
this pull request
Dec 1, 2022
[apex] Summit-AST Apex module - Part 5 - annotations, triggers, misc. #4219
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translate and implement remaining AST nodes, including: fields, triggers, annotations, and parameters.
Fixups from previous code review:
Relates #3766