[java] Support type annotations properly#4197
Merged
Merged
Conversation
Generated by 🚫 Danger |
This is to avoid having rules like UnusedImports fail to see an annotation usage. This makes the tree rather messy when there are type annotations though.
adangel
added a commit
that referenced
this pull request
Nov 11, 2022
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Nov 11, 2022
[java] Support type annotations properly pmd#4197
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Type annotations are parsed properly in (hopefully) all cases, and they do push Annotation nodes on the tree. I initially implemented this in a way that didn't push annotations on the tree, but I think this may throw off rules like UnusedImports, because imports used only in type annotations would be missed. That's why I think it's better to have these nodes in even if they're not as tidy as in PMD 7.
Related issues
Fixes [java] Parse error on array type annotations #4152
Fixes [java] More parser edge cases #3643
Refs [java] Java8 parsing corner case with annotated array types #997
Ready?
./mvnw clean verifypasses (checked automatically by github actions)