Skip to content

[ant] Move ant integration to a new pmd-ant module#4089

Merged
adangel merged 6 commits into
pmd:pmd/7.0.xfrom
oowekyala:pmd7-ant-module
Oct 4, 2022
Merged

[ant] Move ant integration to a new pmd-ant module#4089
adangel merged 6 commits into
pmd:pmd/7.0.xfrom
oowekyala:pmd7-ant-module

Conversation

@oowekyala

@oowekyala oowekyala commented Aug 9, 2022

Copy link
Copy Markdown
Member

Describe the PR

Move ant integration to a new pmd-ant module, according to #4080

Maybe the name of the submodule should be pmd-ant-integration?

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added the dependencies Pull requests that update a dependency file label Aug 9, 2022
@oowekyala oowekyala added this to the 7.0.0 milestone Aug 9, 2022
@ghost

ghost commented Aug 9, 2022

Copy link
Copy Markdown
2 Messages
📖 Compared to pmd/7.0.x:
This changeset changes 24 violations,
introduces 21 new violations, 0 new errors and 0 new configuration errors,
removes 18 violations, 0 errors and 0 configuration errors.
Full report
📖 Compared to master:
This changeset changes 0 violations,
introduces 699661 new violations, 22 new errors and 0 new configuration errors,
removes 826993 violations, 39 errors and 6 configuration errors.
Full report
Compared to pmd/7.0.x:
This changeset changes 26 violations,
introduces 19 new violations, 0 new errors and 0 new configuration errors,
removes 19 violations, 0 errors and 0 configuration errors.
Full report
Compared to master:
This changeset changes 0 violations,
introduces 699658 new violations, 22 new errors and 0 new configuration errors,
removes 826993 violations, 39 errors and 6 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

I'll update the 7_0_0_release_notes and the doc for the CPDTask and merge this.

@adangel adangel linked an issue Oct 4, 2022 that may be closed by this pull request
adangel added a commit that referenced this pull request Oct 4, 2022
adangel added a commit that referenced this pull request Oct 4, 2022
[ant] Move ant integration to a new pmd-ant module #4089
@adangel adangel merged commit 6920d24 into pmd:pmd/7.0.x Oct 4, 2022
@oowekyala oowekyala deleted the pmd7-ant-module branch October 5, 2022 09:58
@adangel adangel mentioned this pull request Jan 23, 2023
55 tasks
Comment thread pmd-test/pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ant] Split off Ant integration into a new submodule

3 participants