[apex] Remove Jorje leaks outside ast package#4081
Merged
Conversation
oowekyala
reviewed
Aug 5, 2022
oowekyala
left a comment
Member
There was a problem hiding this comment.
Thanks for this change! I'm happy to see this moving forward.
In the interest of minimizing divergences between master and your feature branch, I think all the changes to the test sources could be merged as is into master (we don't have compatibility guarantees there).
It would also be possible to introduce new methods (eg getOp) which use the new types, and deprecate the old getOperator methods instead of replacing them and breaking compatibility. If we do that then we could also merge this change into master.
Generated by 🚫 Danger |
oowekyala
reviewed
Aug 6, 2022
oowekyala
reviewed
Aug 9, 2022
ast packageast package
Operators - Create operator enums to wrap internal Jorje operators. - Create getters returning new operator enums in operator-expression nodes. Deprecate old getters. - Refactor metrics classes to use new operator enums. Tests - Remove references to internal Jorje nodes.
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Aug 24, 2022
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Aug 24, 2022
[apex] Remove Jorje leaks outside ast package pmd#4081
This was referenced Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Remove some of the references to the internal Jorje parser outside the
astpackage.Operators
ApexOperatorclass to wrap internal operator classes.ApexOperator.ApexOperator.Tests
Ready?
./mvnw clean verifypasses (checked automatically by github actions)