[test-schema] Add focused attr to the test schema#4058
Merged
Conversation
Generated by 🚫 Danger |
adangel
approved these changes
Jul 22, 2022
adangel
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks!
I was also a bit working on this area... I'll push the following changes to your branch:
- also document "useAuxClasspath" as deprecated in the schema
- remove deprecated usages in our rule test xml files (there are not many)
- delete the not needed code in RuleTst regarding "reinitializeRule" and "useAuxClasspath"
adangel
added a commit
to pmd/pmd.github.io
that referenced
this pull request
Jul 28, 2022
adangel
added a commit
to pmd/pmd.sourceforge.net
that referenced
this pull request
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Add the focused attribute, and deprecate some things in RuleTst.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)