Skip to content

[java] Support Java 19#4038

Merged
oowekyala merged 8 commits into
pmd:masterfrom
adangel:pmd6-java-19
Jul 13, 2022
Merged

[java] Support Java 19#4038
oowekyala merged 8 commits into
pmd:masterfrom
adangel:pmd6-java-19

Conversation

@adangel

@adangel adangel commented Jul 7, 2022

Copy link
Copy Markdown
Member

Describe the PR

Note: I didn't prepare yet a merge to pmd7, that's still on the TODO list...

For pmd7, see #4039

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 6.48.0 milestone Jul 7, 2022
@ghost

ghost commented Jul 7, 2022

Copy link
Copy Markdown
1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@oowekyala oowekyala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, looks good! I can take on the merge to PMD 7 once this is merged if you like

Comment thread pmd-java/etc/grammar/Java.jjt Outdated
Comment thread pmd-java/etc/grammar/Java.jjt Outdated
Comment thread pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTGuard.java Outdated
Comment thread pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTPattern.java Outdated
Comment thread pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTRecordPattern.java Outdated
Comment thread pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTRecordPattern.java Outdated
@adangel

adangel commented Jul 10, 2022

Copy link
Copy Markdown
Member Author

Thanks for the review!
I'll try to do the merge to PMD7 myself first :)

@oowekyala oowekyala self-assigned this Jul 11, 2022
@oowekyala oowekyala merged commit 3a2eb2b into pmd:master Jul 13, 2022
@oowekyala

Copy link
Copy Markdown
Member

Merged, special thanks for the nice documentation!

@adangel adangel deleted the pmd6-java-19 branch July 14, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[java] Support JDK 19

2 participants