Skip to content

[doc] Improve side bar by Adding Release Date#3883

Merged
adangel merged 1 commit into
pmd:masterfrom
jasonqiu98:master
Apr 12, 2022
Merged

[doc] Improve side bar by Adding Release Date#3883
adangel merged 1 commit into
pmd:masterfrom
jasonqiu98:master

Conversation

@jasonqiu98

@jasonqiu98 jasonqiu98 commented Mar 31, 2022

Copy link
Copy Markdown
Contributor

Describe the PR

  • Added the release date under the stable version number on the left sidebar
  • Slightly modified the CSS style and made the release date look natural
  • The local rendering result is shown in the image below
    image

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@jasonqiu98 jasonqiu98 changed the title add release date on sidebar [doc] Improve Sticky Header by Adding Release Date Mar 31, 2022
@adangel adangel self-requested a review April 12, 2022 10:21

@adangel adangel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

Note - you've added it to the sidebar and not the sticky header. But I think, that's ok - I'll rename the issues accordingly.

Please also note - the issue you tackled was originally planned for pmd7 (see milestone in #2505). That would mean to create a PR against the branch "pmd/7.0.x" and not "master". In that case it's a small change that's useful in any version, so I'll move it to pmd6 and merge anyway.

@adangel adangel changed the title [doc] Improve Sticky Header by Adding Release Date [doc] Improve side bar by Adding Release Date Apr 12, 2022
@adangel adangel added this to the 6.45.0 milestone Apr 12, 2022
@adangel adangel added the in:documentation Affects the documentation [doc] label Apr 12, 2022
adangel added a commit to adangel/pmd that referenced this pull request Apr 12, 2022
adangel added a commit to adangel/pmd that referenced this pull request Apr 12, 2022
[doc] Improve side bar by Adding Release Date pmd#3883
@adangel adangel merged commit 6f3dd6c into pmd:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in:documentation Affects the documentation [doc]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants