[xml] Add new XPath rule for xml#3864
Merged
Merged
Conversation
We have to reparse the expression with the correct URI if the input document has an unnamed URI.
Generated by 🚫 Danger |
Rename beginLine to startLine
e0a2c5e to
291be97
Compare
Member
Author
|
@adangel I think this is ready for review, the remaining item is to update the release notes, which I'll do tonight |
adangel
approved these changes
Mar 24, 2022
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
a716884 to
9a43a09
Compare
This reverts commit 6e1e8a6. Note for future: I tried to deprecate the XPath attributes for `@BeginLine`, `@EndLine` etc, but there's a rule I can't port easily without XPath 3: OneDeclarationPerLine. It has this thing: ``` distinct-values(FieldDeclaration/VariableExpression/@BeginLine) ``` In XPath 3 you can write this ``` distinct-values(FieldDeclaration/VariableExpression ! pmd:startLine) ``` But I'm not sure how to do this in XPath 2, so I've reverted the commit, we can do that later.
Member
Author
|
Note for future: I tried to deprecate the XPath attributes for In XPath 3 you can write this But I'm not sure how to do this in XPath 2, so I've reverted the commit, we can do that later. |
adangel
added a commit
that referenced
this pull request
Mar 25, 2022
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Mar 25, 2022
[xml] Add new XPath rule for xml pmd#3864
This was referenced Mar 28, 2022
This was referenced Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Not necessarily for PMD 6.44
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)