[java] Remove old symtable#3839
Merged
Merged
Conversation
Generated by 🚫 Danger |
adangel
approved these changes
Mar 11, 2022
adangel
left a comment
Member
There was a problem hiding this comment.
Thanks!
At some point we should document how to use the new type resolution and symbol table. We have already a good place where to put this -> https://github.com/pmd/pmd/blob/pmd/7.0.x/docs/pages/pmd/languages/java.md
I expect, that this docu will be important for migrating the rules to the new ast. I think, just some example use cases (how do I figure out, where the variable is used? How to check the type? ...) would be enough. But that's for a later :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Remove the old java symbol table and what's left of typeres. Forked off #3831
There's a tree dump test that was previously marked @ignore and whose reference files disappeared at some point, so I'm readding them and reactivating the test.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)