Skip to content

[java] Cleanup java module#3831

Closed
oowekyala wants to merge 20 commits into
pmd:pmd/7.0.xfrom
oowekyala:remove-old-symtable
Closed

[java] Cleanup java module#3831
oowekyala wants to merge 20 commits into
pmd:pmd/7.0.xfrom
oowekyala:remove-old-symtable

Conversation

@oowekyala

@oowekyala oowekyala commented Mar 7, 2022

Copy link
Copy Markdown
Member

Describe the PR

  • Remove the old java symbol table and what's left of typeres
  • Remove deprecated node classes (which are not produced by the parser anymore)
  • Remove TypeNode#getType and other deprecated methods from the Java AST
    • Deprecated AccessNode methods are removed, some reorganization has been done:
      • Java methods isStatic, isPublic, isPrivate, isPackagePrivate and isProtected etc are pushed down to a new interface NonLocalDeclaration. These are still XPath attributes
      • isFinal is removed, the existing interface FinalizableNode is made package-private, its isFinal method is public and non-deprecated
      • Relates to [java] AccessNode API changes #1307

There's a tree dump test that was previously marked @Ignore and whose reference files disappeared at some point, so I'm readding them and reactivating the test.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added this to the 7.0.0 milestone Mar 7, 2022
@oowekyala oowekyala mentioned this pull request Mar 10, 2022
4 tasks
@oowekyala

Copy link
Copy Markdown
Member Author

Will split this into smaller PRs.

@oowekyala oowekyala closed this Mar 10, 2022
@oowekyala oowekyala mentioned this pull request Apr 1, 2022
4 tasks
@oowekyala oowekyala mentioned this pull request Apr 9, 2022
4 tasks
@adangel adangel removed this from the 7.0.0 milestone Jan 6, 2023
@oowekyala oowekyala deleted the remove-old-symtable branch May 13, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants