Skip to content

[java] Fix #3786 - make SimplifyBooleanReturns consider parentheses.#3795

Merged
adangel merged 7 commits into
pmd:pmd/7.0.xfrom
oowekyala:issue3786-simplify-boolean-returns
Feb 25, 2022
Merged

[java] Fix #3786 - make SimplifyBooleanReturns consider parentheses.#3795
adangel merged 7 commits into
pmd:pmd/7.0.xfrom
oowekyala:issue3786-simplify-boolean-returns

Conversation

@oowekyala

Copy link
Copy Markdown
Member

Describe the PR

Also add better error messages to the rule

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added this to the 7.0.0 milestone Feb 18, 2022
@oowekyala oowekyala force-pushed the issue3786-simplify-boolean-returns branch from 264daed to 0032ea1 Compare February 22, 2022 22:25
@ghost

ghost commented Feb 22, 2022

Copy link
Copy Markdown
2 Messages
📖 Compared to pmd/7.0.x:
This changeset changes 366 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 67 violations, 0 errors and 0 configuration errors.
Full report
📖 Compared to master:
This changeset changes 49413 violations,
introduces 26759 new violations, 5 new errors and 0 new configuration errors,
removes 146082 violations, 25 errors and 3 configuration errors.
Full report
Compared to pmd/7.0.x:
This changeset changes 282 violations,
introduces 2 new violations, 0 new errors and 0 new configuration errors,
removes 239 violations, 0 errors and 0 configuration errors.
Full report
Compared to master:
This changeset changes 49413 violations,
introduces 26672 new violations, 5 new errors and 0 new configuration errors,
removes 146165 violations, 25 errors and 3 configuration errors.
Full report

Generated by 🚫 Danger

@oowekyala oowekyala force-pushed the issue3786-simplify-boolean-returns branch 2 times, most recently from 4144d37 to 4e9d2b5 Compare February 23, 2022 00:08
@oowekyala oowekyala force-pushed the issue3786-simplify-boolean-returns branch from 4e9d2b5 to 7adfdfe Compare February 23, 2022 00:34
@adangel adangel linked an issue Feb 25, 2022 that may be closed by this pull request
adangel added a commit that referenced this pull request Feb 25, 2022
adangel added a commit that referenced this pull request Feb 25, 2022
oowekyala:issue3786-simplify-boolean-returns

[java] Fix #3786 - make SimplifyBooleanReturns consider parentheses.
#3795
@adangel adangel merged commit 7adfdfe into pmd:pmd/7.0.x Feb 25, 2022
@oowekyala oowekyala deleted the issue3786-simplify-boolean-returns branch February 25, 2022 14:44
@adangel adangel mentioned this pull request Jan 23, 2023
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[java] SimplifyBooleanReturns should consider operator precedence

2 participants