Skip to content

[java] Update rule BeanMembersShouldSerialize#3659

Merged
oowekyala merged 6 commits into
pmd:pmd/7.0.xfrom
adangel:pmd7-update-BeanMembersShouldSerialize
Jan 4, 2022
Merged

[java] Update rule BeanMembersShouldSerialize#3659
oowekyala merged 6 commits into
pmd:pmd/7.0.xfrom
adangel:pmd7-update-BeanMembersShouldSerialize

Conversation

@adangel

@adangel adangel commented Nov 30, 2021

Copy link
Copy Markdown
Member
  • JavaRuleUtil::isGetter now only accepts "is"-Prefixed getters
    for boolean methods.
  • AbstractLombokAwareRule has been deleted
  • One test case has been deleted - it tested that the rule
    worked without a auxclasspath
  • Another test case has been ignored - in order to resolve
    imports on demand, lombok would need to be on the test aux classpath

Part of #2701

* JavaRuleUtil::isGetter now only accepts "is"-Prefixed getters
  for boolean methods.
* AbstractLombokAwareRule has been deleted
* One test case has been deleted - it tested that the rule
  worked without a auxclasspath
* Another test case has been ignored - in order to resolve
  imports on demand, lombok would need to be on the test aux classpath
@adangel adangel added this to the 7.0.0 milestone Nov 30, 2021
@ghost

ghost commented Nov 30, 2021

Copy link
Copy Markdown
1 Warning
⚠️ Running pmdtester failed, this message is mainly used to remind the maintainers of PMD.
✅ Yay.
Compared to pmd/7.0.x:
This changeset changes 83 violations,
introduces 19963 new violations, 0 new errors and 0 new configuration errors,
removes 1 violations, 0 errors and 0 configuration errors.
Full report
Compared to master:
This changeset changes 45983 violations,
introduces 25849 new violations, 38 new errors and 0 new configuration errors,
removes 162300 violations, 28 errors and 3 configuration errors.
Full report

Generated by 🚫 Danger

@oowekyala oowekyala self-assigned this Dec 31, 2021
@oowekyala oowekyala merged commit 162738d into pmd:pmd/7.0.x Jan 4, 2022
@adangel adangel deleted the pmd7-update-BeanMembersShouldSerialize branch January 8, 2022 19:04
@adangel adangel mentioned this pull request Jan 23, 2023
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants