Skip to content

[java] Update LawOfDemeter#3510

Merged
adangel merged 39 commits into
pmd:pmd/7.0.xfrom
oowekyala:update-LawOfDemeter
Feb 25, 2022
Merged

[java] Update LawOfDemeter#3510
adangel merged 39 commits into
pmd:pmd/7.0.xfrom
oowekyala:update-LawOfDemeter

Conversation

@oowekyala

@oowekyala oowekyala commented Sep 18, 2021 •
edited by adangel
Loading

Copy link
Copy Markdown
Member

Describe the PR

Note: this is the last rule update to be merged, after that we can remove the old symbol table and check more things off of #2701.

Ready?

I expect the diff report to show a lot of differences...

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Document the rule
  • Release notes: document change in the rule and its new property

@oowekyala oowekyala added this to the 7.0.0 milestone Sep 18, 2021
@oowekyala oowekyala mentioned this pull request Sep 18, 2021
Closed
@ghost

ghost commented Sep 18, 2021 •
edited by ghost
Loading

Copy link
Copy Markdown
2 Messages
📖 Compared to pmd/7.0.x:
This changeset changes 88 violations,
introduces 15742 new violations, 2 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
📖 Compared to master:
This changeset changes 57240 violations,
introduces 34717 new violations, 7 new errors and 0 new configuration errors,
removes 138227 violations, 25 errors and 3 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 15730 new violations, 2 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 57155 violations,
introduces 34709 new violations, 7 new errors and 0 new configuration errors,
removes 138229 violations, 25 errors and 3 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 14552 new violations, 2 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 56535 violations,
introduces 34151 new violations, 7 new errors and 0 new configuration errors,
removes 138849 violations, 25 errors and 3 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 17097 new violations, 2 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 57332 violations,
introduces 35899 new violations, 7 new errors and 0 new configuration errors,
removes 138052 violations, 25 errors and 3 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 89 violations,
introduces 15829 new violations, 2 new errors and 0 new configuration errors,
removes 2 violations, 0 errors and 3 configuration errors.
Full report
✅ Compared to master:
This changeset changes 54971 violations,
introduces 36961 new violations, 7 new errors and 0 new configuration errors,
removes 140413 violations, 25 errors and 3 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 89 violations,
introduces 39932 new violations, 2 new errors and 0 new configuration errors,
removes 2 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 67232 violations,
introduces 48803 new violations, 7 new errors and 0 new configuration errors,
removes 128152 violations, 25 errors and 0 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 89 violations,
introduces 41381 new violations, 720 new errors and 0 new configuration errors,
removes 2 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 66760 violations,
introduces 50724 new violations, 725 new errors and 0 new configuration errors,
removes 128624 violations, 25 errors and 0 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 89 violations,
introduces 23425 new violations, 2 new errors and 0 new configuration errors,
removes 2 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 63445 violations,
introduces 36083 new violations, 7 new errors and 0 new configuration errors,
removes 131939 violations, 25 errors and 0 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 89 violations,
introduces 106268 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 135426 violations,
introduces 47029 new violations, 5 new errors and 0 new configuration errors,
removes 60042 violations, 25 errors and 0 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 107001 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 135478 violations,
introduces 47236 new violations, 5 new errors and 0 new configuration errors,
removes 54242 violations, 25 errors and 0 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 56268 new violations, 15 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 72955 violations,
introduces 35720 new violations, 16 new errors and 0 new configuration errors,
removes 95486 violations, 8 errors and 3 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 67628 new violations, 14 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 80836 violations,
introduces 39199 new violations, 15 new errors and 0 new configuration errors,
removes 87605 violations, 8 errors and 3 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 64327 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 80205 violations,
introduces 36529 new violations, 1 new errors and 0 new configuration errors,
removes 88236 violations, 8 errors and 3 configuration errors.
Full report

Generated by 🚫 Danger

@oowekyala oowekyala marked this pull request as ready for review February 6, 2022 15:08
@adangel adangel self-requested a review February 7, 2022 17:32
adangel
adangel reviewed Feb 13, 2022
View reviewed changes

@adangel adangel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not had a close look at the regression tester results - these are just too many :)
But I think, we should try to keep the compatibility via the rule tests...

Comment thread pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/LawOfDemeter.xml Outdated
Comment thread pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/LawOfDemeter.xml Outdated
Comment thread pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/LawOfDemeter.xml Outdated
@oowekyala
Add test cases for fixed issues
e65b119 
- Fixes pmd#2175
- Fixes pmd#2179
- Fixes pmd#1605: same fix as pmd#2179, since enum constants are static fields they are trusted.
- Fixes pmd#2180: the fix is not to special-case Thread, but to consider all static methods as trusted (consistent with the treatment of static fields in pmd#2179)
- Fixes pmd#2182: the fix is not to allow package-private access, but to allow a class to access fields of instances of the same class.
- Fixes pmd#1014
- Fixes pmd#2188
@oowekyala
Fix more bugs
6d1adee
@oowekyala
Allow transformation methods
4a1e417
@oowekyala
Add commonPrefix and commonSuffix to StringUtils
f7e4d62
@oowekyala
Revert "Add commonPrefix and commonSuffix to StringUtils"
1f2aa73 
This reverts commit f7e4d62.
@oowekyala
Fix more fps
ef33d2e
@adangel

adangel commented Feb 25, 2022

Copy link
Copy Markdown
Member

@oowekyala I'll fix the test failures (I think only some TreeDumpTests are failing), update the release notes with the fixed bugs and merge it.

This was linked to issues Feb 25, 2022
[java] LawOfDemeter: False positive with lambda expression #1014
Closed
[java] LawOfDemeter: False positive for standard UTF-8 charset name #1605
Closed
[java] LawOfDemeter: False positive for chained methods with generic method call #2175
Closed
[java] LawOfDemeter: False positive with static property access - should treat class-level property as global object, not dot-accessed property #2179
Closed
[java] LawOfDemeter: False positive with Thread and ThreadLocalRandom #2180
Closed
[java] LawOfDemeter: False positive with package-private access #2182
Closed
[java] LawOfDemeter: False positive with fields assigned to local vars #2188
Closed
adangel added a commit that referenced this pull request Feb 25, 2022
@adangel
[doc] Update release notes for Law Of Demeter (#3510)
f2ac5be 
Issues: #1014 #1605 #2175 #2179 #2180 #2182 #2188
adangel added a commit that referenced this pull request Feb 25, 2022
@adangel
Merge pull request #3510 from oowekyala:update-LawOfDemeter
f21008d 
[java] Update LawOfDemeter #3510
@adangel adangel merged commit e6e707a into pmd:pmd/7.0.x Feb 25, 2022
@oowekyala oowekyala deleted the update-LawOfDemeter branch February 25, 2022 14:43
@adangel adangel mentioned this pull request Jan 23, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment