Skip to content

[java] Update many Java rules#3384

Merged
adangel merged 13 commits into
pmd:pmd/7.0.xfrom
jsotuyod:update-rules
Aug 19, 2021
Merged

[java] Update many Java rules#3384
adangel merged 13 commits into
pmd:pmd/7.0.xfrom
jsotuyod:update-rules

Conversation

@jsotuyod

@jsotuyod jsotuyod commented Jul 6, 2021 •
edited by adangel
Loading

Copy link
Copy Markdown
Member

Describe the PR

Updated:

  • NonStaticInitializer
  • MissingSerialVersionUID
  • InstantiationToGetClass
  • FinalizeShouldBeProtected
  • FinalizeOverloaded
  • FinalizeOnlyCallsSuperFinalize
  • FinalizeDoesNotCallSuperFinalize

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@jsotuyod jsotuyod added this to the 7.0.0 milestone Jul 6, 2021
@jsotuyod jsotuyod mentioned this pull request Jul 6, 2021
Closed
@ghost

ghost commented Jul 7, 2021

Copy link
Copy Markdown
1 Warning
⚠️ Running pmdtester failed, this message is mainly used to remind the maintainers of PMD.

Generated by 🚫 Danger

@jsotuyod

jsotuyod commented Jul 7, 2021

Copy link
Copy Markdown
Member Author

@adangel @oowekyala any idea of why the regression tester may be failing?

It reports a bunch of NPEs, but some of them even occur on rules such as SuspiciousHashcodeMethodNameRule which are still commented out in .ci/files/all-java.xml

@oowekyala

oowekyala commented Jul 7, 2021

Copy link
Copy Markdown
Member

I think if you only edit one category file, the regression tester executes the category (ignoring the .ci/files/all-java.xml). This is annoying and should probably be removed from the regression tester while we update rules for pmd 7.

IIRC you can workaround this by touching eg codestyle.xml and adding a newline or something harmless. But this also applies to many other open prs...

@oowekyala oowekyala mentioned this pull request Jul 11, 2021
Merged
4 tasks
@oowekyala oowekyala changed the title Update many Java rules [java] Update many Java rules Jul 11, 2021
@adangel

adangel commented Jul 15, 2021

Copy link
Copy Markdown
Member

@jsotuyod Please merge in the latest pmd/7.0.x - this should make the regression tester run again (see #3399).

@adangel

adangel commented Jul 16, 2021

Copy link
Copy Markdown
Member

Or enable the following checkbox in this PR:

grafik

Then I can push to your branch...

@oowekyala

oowekyala commented Aug 7, 2021

Copy link
Copy Markdown
Member

Or enable the following checkbox in this PR:

grafik

Then I can push to your branch...

@jsotuyod Please do this so we can help finish this pr

@adangel adangel self-assigned this Aug 19, 2021
@adangel adangel mentioned this pull request Aug 19, 2021
Merged
adangel added a commit that referenced this pull request Aug 19, 2021
@adangel
Merge pull request #3384 from Monits:update-rules
3a7f264 
[java] Update many Java rules #3384
@adangel adangel merged commit 9f72026 into pmd:pmd/7.0.x Aug 19, 2021
@jsotuyod jsotuyod deleted the update-rules branch August 23, 2021 15:23
@adangel adangel mentioned this pull request Jan 23, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@adangel adangel

Labels

None yet

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jsotuyod @oowekyala @adangel